Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hash bundle support to Zoe install #4974

Closed
kriskowal opened this issue Mar 31, 2022 · 1 comment
Closed

Add hash bundle support to Zoe install #4974

kriskowal opened this issue Mar 31, 2022 · 1 comment
Assignees
@kriskowal
Labels
enhancement New feature or request

Comments

@kriskowal
Copy link
Member

What is the Problem Being Solved?

Zoe currently accepts bundles that contain all of their source, resulting in very large transactions to the chain. Per #4563, we added a new installation method to Zoe, installBundleID that allows a bundle to be published to the SwingSet controller without a chain transaction and then install it in Zoe using its “identifier” (tagged consistent hash).

@michaelfig observes that install is already sufficiently generic to support an evolving bundle payload type. @dckc observes that this change also avalanches through our documentation #4565 (comment).

Description of the Design

So, instead, the plan is to consolidate the behavior of installBundleID into install and instead introduce a new “hash bundle” type that would be accepted by install in addition to “source bundles”, and eventually instead of source bundles #4565.

Security Considerations

Test Plan
@kriskowal kriskowal added the enhancement New feature or request label Mar 31, 2022
@kriskowal kriskowal mentioned this issue Mar 31, 2022
Open
@kriskowal kriskowal self-assigned this Mar 31, 2022
kriskowal added a commit that referenced this issue Mar 31, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
f1a2aca
@kriskowal kriskowal mentioned this issue Mar 31, 2022
Merged
@dckc dckc mentioned this issue Apr 8, 2022
Closed
@kriskowal kriskowal mentioned this issue Apr 12, 2022
Open
kriskowal added a commit that referenced this issue Apr 21, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
95402c2
kriskowal added a commit that referenced this issue Apr 22, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
f38b3ab
kriskowal added a commit that referenced this issue Apr 28, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
dbb04d1
kriskowal added a commit that referenced this issue Apr 28, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
66c84d6
kriskowal added a commit that referenced this issue Apr 28, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
8fbfc6d
kriskowal added a commit that referenced this issue May 2, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
4ba344b
kriskowal added a commit that referenced this issue May 2, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
d01bfcd
kriskowal added a commit that referenced this issue May 3, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
24cd777
kriskowal added a commit that referenced this issue May 3, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
b82314e
kriskowal added a commit that referenced this issue May 25, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
0bc8287
kriskowal added a commit that referenced this issue May 25, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
046e8dd
kriskowal added a commit that referenced this issue May 25, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
e9c99a1
kriskowal added a commit that referenced this issue May 25, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
8d13e72
kriskowal added a commit that referenced this issue May 26, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
7b0b1e5
kriskowal added a commit that referenced this issue May 27, 2022
@kriskowal
fix(zoe): Note #4974 subsume installBundleID in install
815c035
@kriskowal
Copy link
Member Author

Solved in #4975

@Chris-Hibbert Chris-Hibbert mentioned this issue Dec 11, 2023
Merged
@Chris-Hibbert Chris-Hibbert mentioned this issue Dec 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kriskowal kriskowal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kriskowal