Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoe reveal whether (to what extent) an Offer's want was satisfied #5818

Closed
Chris-Hibbert opened this issue Jul 25, 2022 · 0 comments · Fixed by #5905
Closed

Zoe reveal whether (to what extent) an Offer's want was satisfied #5818

Chris-Hibbert opened this issue Jul 25, 2022 · 0 comments · Fixed by #5905
Assignees
Labels
enhancement New feature or request Zoe package: Zoe

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

Zoe's guarantee is that at least one of the user's give and want were satisfied. (With multiples #5422, we will have to ask how many times the want was satisfied). Contracts shouldn't be trusted to answer this question. So Zoe should at least provide a helper that gives a simple answer to the question "Did my trade go through?"

Description of the Design

In addition to userSeat.hasExited(), we could add userSeat.wantSatisfied(). For now, it would be a Promise that resolves to 0 or 1. With Multiples, the number might be greater than 1. The holder of the userSeat would still have to check whether any of the give was returned, as that is orthogonal.

Security Considerations

Doesn't reveal anything that should be hidden.

Test Plan

straightforward. also ensure that the result is reasonable with various forms of exit.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Zoe package: Zoe labels Jul 25, 2022
@Chris-Hibbert Chris-Hibbert added this to the Mainnet 1 milestone Jul 25, 2022
@Chris-Hibbert Chris-Hibbert self-assigned this Jul 25, 2022
@Tartuffo Tartuffo removed this from the Mainnet 1 RC0 milestone Aug 10, 2022
@mergify mergify bot closed this as completed in #5905 Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Zoe package: Zoe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants