feat(zoe): multiples, for making divisible offers #5422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is nice! I think it will work for the most obvious cases. I don't know how to think about the corner cases without an outline of the expected usage pattern. With that, someone other than you (@erights) could conceivably finish this. |
|
SGTM! This is quite interesting. I'll have to sequence it with MN-1 priorities. Is this aiming for that release?
Same here, I would need at least some description of tests of multiples > 1. |
8 tasks
erights
force-pushed
the
markm-amount-pattern
branch
from
ce63012
to
8dccd80
Compare
erights
force-pushed
the
markm-multiples
branch
2 times, most recently
from
ccca6f0
to
32ab2c7
Compare
erights
force-pushed
the
markm-multiples
branch
3 times, most recently
from
fd606ba
to
97da179
Compare
erights
changed the title
erights
force-pushed
the
markm-multiples
branch
from
97da179
to
d26c71a
Compare
turadg
changed the title
erights
force-pushed
the
markm-normalize-golden-error-prop-order
branch
from
2b091b7
to
20556bc
Compare
erights
force-pushed
the
markm-normalize-golden-error-prop-order
branch
from
20556bc
to
d31700e
Compare
erights
force-pushed
the
markm-normalize-golden-error-prop-order
branch
from
d31700e
to
54ad6fe
Compare
erights
force-pushed
the
markm-normalize-golden-error-prop-order
branch
from
54ad6fe
to
cce4b1f
Compare
erights
force-pushed
the
markm-multiples
branch
from
515f7a9
to
b91c50d
Compare
erights
force-pushed
the
markm-normalize-golden-error-prop-order
branch
3 times, most recently
from
75235df
to
5099403
Compare
erights
force-pushed
the
markm-multiples
branch
from
b91c50d
to
45ee413
Compare
erights
force-pushed
the
markm-normalize-golden-error-prop-order
branch
from
5099403
to
d174705
Compare
erights
changed the base branch from
markm-normalize-golden-error-prop-order
to
master
erights
force-pushed
the
markm-multiples
branch
3 times, most recently
from
0141042
to
8098838
Compare
erights
force-pushed
the
markm-multiples
branch
2 times, most recently
from
8480168
to
24c34c2
Compare
erights
force-pushed
the
markm-multiples
branch
2 times, most recently
from
b23bb40
to
c2d29a5
Compare
erights
force-pushed
the
markm-multiples
branch
2 times, most recently
from
c8f8568
to
19dc550
Compare
erights
force-pushed
the
markm-multiples
branch
from
19dc550
to
2d1bddc
Compare
erights
force-pushed
the
markm-multiples
branch
from
2d1bddc
to
e3fa06f
Compare
erights
force-pushed
the
markm-multiples
branch
from
e3fa06f
to
329da68
Compare
erights
force-pushed
the
markm-multiples
branch
from
329da68
to
56b9ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMG Multiples! But tested only that we didn't break anything, because everything currently uses only
multiples: 1n.refs: #403, #5540
@Chris-Hibbert @dtribble @mhofman @turadg , once ready for review, I will ask you to review. Until then, please ignore. (@turadg , I cannot unlist you because of codeowners. @Chris-Hibbert I cannot and should not unlist you since you already commented.)