smart wallet: withdraw payments before getting invitation #7098
Labels
enhancement
New feature or request
performance
Performance related issues
vaults_triage
DO NOT USE
wallet
Comments
dckc
added
enhancement
dckc
added a commit
that referenced
this issue
Aug 1, 2023
This performance optimization avoids all the work of getting an invitation if there aren't sufficient funds for `proposal.give`. fixes: #7098
dckc
added a commit
that referenced
this issue
Aug 1, 2023
This performance optimization avoids all the work of getting an invitation if there aren't sufficient funds for `proposal.give`. fixes: #7098
dckc
added a commit
that referenced
this issue
Aug 1, 2023
This performance optimization avoids all the work of getting an invitation if there aren't sufficient funds for `proposal.give`. fixes: #7098
dckc
added a commit
that referenced
this issue
Aug 1, 2023
This performance optimization avoids all the work of getting an invitation if there aren't sufficient funds for `proposal.give`. fixes: #7098
turadg
pushed a commit
that referenced
this issue
Aug 3, 2023
This performance optimization avoids all the work of getting an invitation if there aren't sufficient funds for `proposal.give`. fixes: #7098
mhofman
pushed a commit
that referenced
this issue
Aug 7, 2023
This performance optimization avoids all the work of getting an invitation if there aren't sufficient funds for `proposal.give`. fixes: #7098
anilhelvaci
pushed a commit
to anilhelvaci/agoric-sdk
that referenced
this issue
Aug 16, 2023
This performance optimization avoids all the work of getting an invitation if there aren't sufficient funds for `proposal.give`. fixes: Agoric#7098
dckc
added a commit
that referenced
this issue
Sep 4, 2023
This performance optimization avoids all the work of getting an invitation if there aren't sufficient funds for `proposal.give`. fixes: #7098
dckc
added a commit
that referenced
this issue
Sep 8, 2023
This performance optimization avoids all the work of getting an invitation if there aren't sufficient funds for `proposal.give`. fixes: #7098
dckc
added a commit
that referenced
this issue
Sep 8, 2023
This performance optimization avoids all the work of getting an invitation if there aren't sufficient funds for `proposal.give`. fixes: #7098
|
fixed in 33f2859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
In the case of trying to open a vault when the collateral amount in the offer is more than the sender has in their account, a bunch of work is done to make an invitation and an offer, only to have the offer execution fail.
Description of the Design
Withdraw payments before starting to construct an invitation.
Even though
E(zoe).offer()accepts promises for payments, make sure the.withdraw()promises are settled before contacting the vaults contract or zoe to do more work.Security Considerations / Scaling Considerations
unlikely to introduce any
Test Plan
This change is invisible via most APIs, so I'm not sure what a good test would look like.
cc @turadg
The text was updated successfully, but these errors were encountered: