Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap config: uniform treatment of contract terms, governance parameters #7309

Open
3 tasks
dckc opened this issue Apr 2, 2023 · 3 comments
Open
3 tasks
Assignees
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request technical-debt

Comments

@dckc
Copy link
Member

dckc commented Apr 2, 2023

Problem

One solution to more frequent auctions for testing (#7249) would be to give a value for StartFrequency in the config file when starting the chain. But the config.auctionParams in startAuctioneer isn't wired up to the config file.

The connections between initial governance parameter values (and contract terms) and config file options is incomplete and ad-hoc.

Plus, the value for StartFrequency includes the timerBrand, and we can't put objects such as that directly in JSON config files. Likewise bignums, ratios. We have various ad-hoc conventions for building objects from JSON data in config files.

Design

  • a uniform mechanism to set the initial value of any governance parameter
    • perhaps a small expression language... akin to Justin, but embedded in JSON. the smartWallet callPipe is similar.
  • likewise for contract terms

Goals (optional):

@dckc dckc added cosmic-swingset package: cosmic-swingset enhancement New feature or request labels Apr 2, 2023
@dckc dckc changed the title uniform treatment of contract terms, governance parameters bootstrap config: uniform treatment of contract terms, governance parameters Apr 2, 2023
@dckc dckc self-assigned this Apr 2, 2023
@dckc
Copy link
Member Author

dckc commented Apr 21, 2023

Looks like our ad-hoc treatment of initial settings bit us again today for oracle testing.

the minSubmissionCount is set to 1 not 3
we need to override DEFAULT_CONTRACT_TERMS around
https://github.com/Agoric/agoric-sdk/blob/master/packages/vats/decentral-devnet-config.json#L116

cc @michaelfig

@Chris-Hibbert
Copy link
Contributor

@dckc is aware of this, but for others following along, minSubmissionCount is addressed somewhat in #7583. If it needs to be modified in other places, that PR demonstrates an approach that works.

@dckc
Copy link
Member Author

dckc commented May 11, 2023

took some extra time while thinking about #7683 to explore this a little...

config-schema.json
2023-05-11 08:15 febe1f0 feat: generate schema for swingset config

see also notes in discord thread:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request technical-debt
Projects
None yet
Development

No branches or pull requests

2 participants