Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tweak auction params based on testing experience #7683

Merged
merged 1 commit into from
May 11, 2023
Merged

chore: tweak auction params based on testing experience #7683

merged 1 commit into from
May 11, 2023

Conversation

dckc
Copy link
Member

@dckc dckc commented May 10, 2023 •
edited
Loading

in collaboration with Rowland

closes: #7688
refs: #7311

Description

  • auction params
  • default manager params
    • interestRate 2.5%
    • liquidationPadding 20n
    • liquidationMargin 230n
    • liquidationPenalty 10n

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

@dckc dckc requested a review from turadg May 10, 2023 21:51
@dckc dckc marked this pull request as draft May 10, 2023 22:01
This was referenced May 10, 2023
Closed
Open
@dckc
Copy link
Member Author

dckc commented May 11, 2023

reverting the manager changes; @ivanlei tells me they're not critical

@dckc dckc marked this pull request as ready for review May 11, 2023 14:45
@dckc
Copy link
Member Author

dckc commented May 11, 2023

CI is green (pending chain deployment test); PTAL.

ivanlei
ivanlei approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@ivanlei ivanlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚢

@dckc dckc added this pull request to the merge queue May 11, 2023
Merged via the queue into master with commit cab24ad May 11, 2023
@dckc dckc deleted the dc-auction-params branch May 11, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert left review comments

@ivanlei ivanlei ivanlei approved these changes

@turadg turadg Awaiting requested review from turadg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default parameter values based on testing experience and outside input
4 participants
@dckc @turadg @ivanlei @Chris-Hibbert