Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vstorage module path validation regular expression is incorrect #8337

Closed
gibson042 opened this issue Sep 15, 2023 · 0 comments · Fixed by #8348
Closed

vstorage module path validation regular expression is incorrect #8337

gibson042 opened this issue Sep 15, 2023 · 0 comments · Fixed by #8348
Assignees
@gibson042
Labels
bug Something isn't working security

Comments

@gibson042
Copy link
Member

Describe the bug

pathPattern is intended to check that a provided path consists exclusively of letters, numbers, underscores, ASCII dashes, and separating periods, but because it lacks anchoring, it actually matches any provided path.

To Reproduce

This cannot be reproduced from the JS side, because vat-bridge chainStorageNodes have their own validation.

Expected behavior

The vstorage module should clearly document constraints on paths, and reject any attempt to use a path that does not conform with them.
@gibson042 gibson042 added the bug Something isn't working label Sep 15, 2023
@gibson042 gibson042 self-assigned this Sep 15, 2023
gibson042 added a commit that referenced this issue Sep 18, 2023
@gibson042
fix(vstorage)!: Enforce path validation
a0ffaba 
Fixes #8337
@gibson042 gibson042 mentioned this issue Sep 18, 2023
Merged
gibson042 added a commit that referenced this issue Sep 19, 2023
@gibson042
fix(vstorage)!: Enforce path validation
03871e8 
Fixes #8337
@mergify mergify bot closed this as completed in #8348 Sep 19, 2023
mhofman pushed a commit that referenced this issue Nov 8, 2023
@gibson042 @mhofman
fix(vstorage)!: Enforce path validation
c6aad66 
Fixes #8337
mhofman pushed a commit that referenced this issue Nov 10, 2023
@gibson042 @mhofman
fix(vstorage)!: Enforce path validation
d8db331 
Fixes #8337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibson042 gibson042

Labels
bug Something isn't working security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(vstorage)!: Enforce path validation Agoric/agoric-sdk
2 participants
@gibson042 @raphdev