Orchestration contract dependencies make them too large for Mainnet #9900
Assignees
Labels
enhancement
New feature or request
Comments
turadg
changed the title
|
See also endojs/endo#2411 |
|
There might be a small win in reducing |
|
|
mergify bot
added a commit
that referenced
this issue
Aug 31, 2024
refs: #9900 ## Description This uses the new `--elide-comments` option in Endo bundle-source to… elide comments. Always. Measured with: ``` cd a3p-integration rm -f **/b1-*.json* yarn build:submissions du -csh **/b1-*.json gzip **/b1-*.json du -csh **/b1-*.json.gz ``` Before: 26M (6.7M gz) After: 19M (4.1M gz) ### Security Considerations No change in runtime. Does affect code auditability. Existing bundles are base64 encoded so readers will have to find the sources anyway. Either way we will need to invest in special tooling: endojs/endo#1656 ### Scaling Considerations reduces on-chain storage ### Documentation Considerations End users who base64 decode the on-chain bundles will no longer see comments… I don't expect anyone was doing this. ### Testing Considerations existing coverage ### Upgrade Considerations won't affect any existing deployments
|
multichain-testing now has the same limit as in Mainnet and it installs contracts like If we hit hit up against it again we can re-open this issue and work down the list of optimizations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
Bundles of contracts using Orchestration tend to be over 500KB, the limit for deploying to Mainnet. E.g. https://github.com/Agoric/dapp-orchestration-basics/pull/17/files#diff-1033217b1ee0740bea6f7c4bf49634318af4e0b4420a6048f55a686f3d5cfee5R56
@agoric/cosmic-protois meant to be used in vats, UIs and contracts. Contracts have strict size limits to fit onto Mainnet and some of the codegen files in@agoric/cosmic-protoare huge.When importing a module, the caller should only need to import (and bundle) what will be used. But right now importing the package main or
helpersmodule will pull inabci/types.jswhich is over 100KB.Description of the Design
Reduce overall weight of deps
Dupes should be prevented. Egregious export graphs should be trimmed but we shouldn't go down a rabbit hole optimizing these.
#8621 is also a factor but easily mitigated by deduping node_modules (with Yarn resolutions)
Stop export of cosmos-interchain-service from package main
Stop import of
abci/types.jsinhelpers(by movingtoRequestQueryJsoninto another module)https://github.com/Agoric/dapp-orchestration-basics/tree/ta/mainnet-size has some experiments
Strip comments during bundling
Next thing to try:
Externalize deps (Import from env)
Next biggest lift:
Import between bundles
Maybe never…
Security Considerations
Scaling Considerations
Test Plan
Upgrade Considerations
The text was updated successfully, but these errors were encountered: