Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove config override #10043

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

0xpatrickdev
Copy link
Member

@0xpatrickdev 0xpatrickdev commented Sep 6, 2024

incidental

Description

With #9997, we no longer need to override the update-config.sh script that edits config.toml - the default works fine. See #9997 (comment)

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

n/a

Upgrade Considerations

n/a

- with #9997, we no longer need to override config.toml script - the defaults work fine
@0xpatrickdev 0xpatrickdev added the force:integration Force integration tests to run on PR label Sep 6, 2024
Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: b9fa3ed
Status: ✅  Deploy successful!
Preview URL: https://3932dd38.agoric-sdk.pages.dev
Branch Preview URL: https://pc-starship-custom-config.agoric-sdk.pages.dev

View logs

@0xpatrickdev 0xpatrickdev marked this pull request as ready for review September 6, 2024 21:15
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ✂️

@0xpatrickdev
Copy link
Member Author

darn, something isn't working for the hermes relayers connected to agoric:

ERROR error raised while creating client for chain agoriclocal: failed sending message to dst chain : error in underlying transport when making gRPC call: transport error
2024-09-06T21:48:37.946658Z ERROR ThreadId(01) foreign_client.create{client=gaialocal->agoriclocal:07-tendermint-0}: failed to create client: error raised while creating client for chain agoriclocal: failed sending message to dst chain : error in underlying transport when making gRPC call: transport error

We've bumped the helm chart a few times since checking in the override, so maybe that's the source of the issue. Will take a look Monday

@0xpatrickdev 0xpatrickdev marked this pull request as draft September 6, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants