feat: use orchFns.autoStake as target for receiveUpcall
#10065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses an async-flow function as the handler for a `.monitorTransfers()` tap - allows guest develoeprs to write handlers as flows instead of with vows and watchers
Deploying agoric-sdk with
|
| Latest commit: |
5b8b568
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72c52e85.agoric-sdk.pages.dev |
| Branch Preview URL: | https://10047-monitor-transfers-flow.agoric-sdk.pages.dev |
0xpatrickdev
commented
Sep 11, 2024
| trace('receiveUpcall', event); | ||
| const { localAccount, stakingAccount, config } = this.state; | ||
| // eslint-disable-next-line no-use-before-define -- defined by orchestrateAll, necessarily after this | ||
| orchFns.autoStake(localAccount, stakingAccount, config, event); |
There was a problem hiding this comment.
I wanted to do orchFns.autoStake(this.state, event) here, and call it ~(continuingOfferCtx, event) on the other end, but was greeted with Error: cannot serialize Remotables with accessors like "localAccount"
There was a problem hiding this comment.
you might try passing a copy with normal properties rather than accessors {... this.state }.
0xpatrickdev
commented
Sep 11, 2024
Comment on lines
+29
to
+30
| * stakingAccount: GuestInterface<CosmosOrchestrationAccount>; | ||
| * localAccount: GuestInterface<LocalOrchestrationAccount>; |
There was a problem hiding this comment.
If we use OrchestrationAccount<any>, which the flow is expecting, we see Argument of type '<OrchestrationAccount<any>>' is not assignable to parameter of type 'Passable'. on L105.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10047
Description
Rework
auto-stake-it.contract.jsto use an orchestrated async-flow as the handler for.monitorTransfers()(vtransfer). Previously, it was written using vows and watchers.To Do
ts-expect-error's introducedSecurity Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
Better example code for prospective developers.
Testing Considerations
Existing tests should pass.
Upgrade Considerations
n/a, example code