remove orch.makeLocalAccount
#10260
Merged
remove orch.makeLocalAccount
#10260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
force-pushed
the
10106-remove-makeLocalAccount
branch
from
6f6ec04
to
17a1001
Compare
Deploying agoric-sdk with
|
| Latest commit: |
fa13c4e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://564961cf.agoric-sdk.pages.dev |
| Branch Preview URL: | https://10106-remove-makelocalaccoun.agoric-sdk.pages.dev |
0xpatrickdev
force-pushed
the
10106-remove-makeLocalAccount
branch
from
17a1001
to
fb69394
Compare
turadg
approved these changes
Oct 11, 2024
| * chainHub: ChainHub; | ||
| * localchain: Remote<LocalChain>; | ||
| * makeRecorderKit: MakeRecorderKit; |
There was a problem hiding this comment.
I expect some of these will need to be restored later but I agree it's better to leave them out until they're used
0xpatrickdev
force-pushed
the
10106-remove-makeLocalAccount
branch
2 times, most recently
from
b6e0883
to
3356749
Compare
0xpatrickdev
force-pushed
the
10106-remove-makeLocalAccount
branch
from
3356749
to
fa13c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10106
Description
There doesn't seem to be a motivating use case for exposing a maker for a low-level
LocalChainAccountin theOrchestrator, so lets remove it to avoid misdirection. Instead, consumers can callorch.getChain('agoric').then(c => c.makeAccount())to get aLocalOrchestrationAccount.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
docs.agoric.com already reflects this: Agoric/documentation#1208 (comment)
Testing Considerations
Removing code, so existing tests suffice
Upgrade Considerations
Library code that will go out in a NPM Orch Release