Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agoric): make agoric --sdk install use yarn link #1303

Merged
merged 5 commits into from
Aug 1, 2020

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Jul 17, 2020

This makes it possible to have dapp package dependencies diverge
from agoric-sdk's.

The necessary diff for dapp-encouragement is: https://github.com/Agoric/dapp-encouragement/compare/daa362...34abf0

@michaelfig michaelfig added the agoric-cli package: agoric-cli label Jul 17, 2020
@michaelfig michaelfig self-assigned this Jul 17, 2020
@katelynsills
Copy link
Contributor

I'm going to let Kris take a look at this one. I skimmed through but don't entirely understand the change. I like the concept though.

Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

packages/agoric-cli/lib/install.js Outdated Show resolved Hide resolved
@michaelfig michaelfig force-pushed the mfig/agoric-cli-sdk-yarn-link branch 3 times, most recently from a7be765 to a44421d Compare July 20, 2020 18:04
@katelynsills katelynsills removed their request for review July 27, 2020 18:10
@michaelfig michaelfig force-pushed the mfig/agoric-cli-sdk-yarn-link branch from a44421d to e1cb6f2 Compare August 1, 2020 01:16
This is necessary to prevent version conflicts due to outdated
dapps.
@michaelfig michaelfig merged commit b2c980a into master Aug 1, 2020
@michaelfig michaelfig deleted the mfig/agoric-cli-sdk-yarn-link branch August 1, 2020 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cli package: agoric-cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants