-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VatTP-over-IBC #1338
Add VatTP-over-IBC #1338
Conversation
69b2629
to
e46cad9
Compare
e46cad9
to
86fbdbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okfinewhatever
@@ -164,7 +164,7 @@ func handleMsgProvision(ctx sdk.Context, keeper Keeper, msg MsgProvision) (*sdk. | |||
} | |||
|
|||
// Create the account, if it doesn't already exist. | |||
egress := types.NewEgress(msg.Nickname, msg.Address) | |||
egress := types.NewEgress(msg.Nickname, msg.Address, msg.PowerFlags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in thinking that the author of the ProvisionOne
transaction can choose whatever PowerFlags
they want (i.e. the single "give them everything" one we added, which only actually gives them the ability to set up network connections), but these transactions will only be accepted in messages signed by keys associated with accounts that hold a provisionpass
token? And that this PR doesn't show the provisionpass
check because that was already present in the previous revisions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no "give them everything" flag when running on a real chain. That only exists when running on the fake chain. You are correct that this is checked against the provisionpass
, which was already present.
86fbdbc
to
5b68af5
Compare
This implements the demo described in #259.