-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [WIP] steps towards zcf.mintAllocation #1380
Conversation
…maining "canExit" and afterDeadline wakeup that should be function rather than immediate call
upgraded barter contract and its tests to newest Zoe API Added zoe.getPublicFacet(instance)
…#1369) * refactor: use the instanceRecord that already exists in instanceAdmin * fix type of getTerms
Because of the squash of new-zoe-spike-2, I don’t know how to rebase or indicate the common ancestor. This falls in the cracks of my git knowledge. HELP. |
There might be a better way to do it, but depending on how many changes you made, if you've only changed a few files, I would create a new branch from new-zoe-spike-2 and do |
@@ -145,6 +145,35 @@ export function buildRootObject() { | |||
getBrandForIssuer: issuer => | |||
issuerTable.getIssuerRecordByIssuer(issuer).brand, | |||
getAmountMath, | |||
|
|||
makeZCFMint: (keyword, mathHelperName = 'nat') => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makeLocalMint
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I often use "localFoo" to mean a Foo that is here in this vat rather than possibly remote in some other vat. But I don't like "ZCF" here either. We need a new name.
Replaced by #1382 so closing |
An old test still passes, which is evidence only that I didn't break many old things. None of the new logic can yet be run. But it should have enough shape to discuss.