Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [WIP] steps towards zcf.mintAllocation #1380

Closed
wants to merge 17 commits into from

Conversation

erights
Copy link
Member

@erights erights commented Aug 6, 2020

An old test still passes, which is evidence only that I didn't break many old things. None of the new logic can yet be run. But it should have enough shape to discuss.

@erights
Copy link
Member Author

erights commented Aug 6, 2020

Because of the squash of new-zoe-spike-2, I don’t know how to rebase or indicate the common ancestor. This falls in the cracks of my git knowledge. HELP.

@katelynsills
Copy link
Contributor

Because of the squash of new-zoe-spike-2, I don’t know how to rebase or indicate the common ancestor. This falls in the cracks of my git knowledge. HELP.

There might be a better way to do it, but depending on how many changes you made, if you've only changed a few files, I would create a new branch from new-zoe-spike-2 and do git checkout -- filepath for the different files you want to include. That will lay the changes in the files on top of the branch.

@@ -145,6 +145,35 @@ export function buildRootObject() {
getBrandForIssuer: issuer =>
issuerTable.getIssuerRecordByIssuer(issuer).brand,
getAmountMath,

makeZCFMint: (keyword, mathHelperName = 'nat') => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeLocalMint?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I often use "localFoo" to mean a Foo that is here in this vat rather than possibly remote in some other vat. But I don't like "ZCF" here either. We need a new name.

@erights
Copy link
Member Author

erights commented Aug 6, 2020

Replaced by #1382 so closing

@erights erights closed this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants