refactor: bring autoswap up to date on the new Zoe spike branch #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katelynsills
approved these changes
Aug 10, 2020
| throw new Error('getPoolKeyword: brand not found'); | ||
| }; | ||
|
|
||
| const { zcfSeat: poolSeat } = await zcf.addEmptySeat(); |
There was a problem hiding this comment.
is this meant to be async? If so, why not use makeEmptyOffer?
There was a problem hiding this comment.
Dropped the async. Thanks.
| }); | ||
|
|
||
| return { publicFacet, creatorFacet: publicFacet }; |
There was a problem hiding this comment.
Ooo nice, I like the concept of passing the publicFacet back as the creatorFacet. We might consider always passing the publicFacet back to the creator too.
|
addresses #1267, for autoswap. I think that bug also refers to multipoolAutoswap, so I won't close it. |
Based on the synchronous seat work. The unit tests for autoswap pass. I haven't yet done the swingset tests.
No, it was my oversight. |
Chris-Hibbert
force-pushed
the
autoswap
branch
from
1702c1c
to
1016d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the autoswap contract up-to-date on the new-zoe-spike-2 branch, based on the synchronous seat work.
The unit tests for autoswap pass. I haven't yet done the swingset tests.