Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade back to allowing 12.14.1 to work #1467

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Aug 14, 2020

We didn't need to upgrade to 12.16.1, so let's move back to supporting 12.14.1.

Note that the 5 expected checks below have hardcoded the 12.16.1 in their test title in the branch protection rules. If this PR is merged, we will need to adjust the rules.

@michaelfig michaelfig self-assigned this Aug 14, 2020
@michaelfig michaelfig added the tooling repo-wide infrastructure label Aug 14, 2020
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Do you want me to disable the branch protection while you land this, and then switch it back on afterwards with the different test names?

@warner
Copy link
Member

warner commented Aug 14, 2020

Oh, I see, the test names are descriptive outputs, not inputs.. we shouldn't need to modify the config.

@michaelfig michaelfig merged commit 32791e1 into master Aug 14, 2020
@michaelfig michaelfig deleted the mfig/node-12.14.1 branch August 14, 2020 05:04
@michaelfig
Copy link
Member Author

Oh, I see, the test names are descriptive outputs, not inputs.. we shouldn't need to modify the config.

Not exactly sure what you mean. I had to modify the .github/workflows to use 12.14.1 instead of 12.16.1. I also had to modify the branch protection to use 12.x instead of 12.16.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling repo-wide infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants