Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave patch-package as an option #1468

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Conversation

michaelfig
Copy link
Member

Sometimes depd causes problems with other Node engines (I'm looking at you, Electron), so I'd suggest leaving this patch-package option available to unblock people who might find this note from the future:

If you see the following:

/Users/michael/agoric/agoric-sdk/node_modules/depd/index.js:1
TypeError: callSite.getFileName is not a function
   at callSiteLocation (/Users/michael/agoric/agoric-sdk/node_modules/depd/index.js:252:23)
   at depd (/Users/michael/agoric/agoric-sdk/node_modules/depd/index.js:111:14)
  at Object.<anonymous> (/Users/michael/agoric/agoric-sdk/node_modules/body-parser/index.js:14:32)
   at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)

then you need to run yarn patch-package

@michaelfig michaelfig requested a review from warner August 14, 2020 03:07
@michaelfig michaelfig self-assigned this Aug 14, 2020
@michaelfig michaelfig added the tooling repo-wide infrastructure label Aug 14, 2020
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch won't be applied unless you run the explicit command, so I think that's safe. Ideally we'll remove this when we figure out how to fix/workaround/untame/something the depd problem.

@michaelfig
Copy link
Member Author

The patch won't be applied unless you run the explicit command, so I think that's safe. Ideally we'll remove this when we figure out how to fix/workaround/untame/something the depd problem.

Agreed. I wish I had steps to reproduce that didn't involve running Electron. 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling repo-wide infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants