Refactor publicAuction, rename to secondPriceAuction #1562
Conversation
katelynsills
force-pushed
the
1482-auction
branch
from
8547396
to
904d5a1
Compare
| const assetWanted = bidSeat.getAmountAllocated('Asset', assetAtAuction.brand); | ||
| assert( | ||
| assetMath.isGTE(assetAtAuction, assetWanted), | ||
| details`more assets were wanted ${assetWanted} than were available ${assetAtAuction}`, |
There was a problem hiding this comment.
This would be helpful if we had a standard way of rendering assets. Are you planning to add that at some point? Otherwise, I'm not sure this is very helpful.
There was a problem hiding this comment.
This will show the brand and value, so if the value is a Nat, it is already helpful. And we have an issue to display brands and other presences better. So I think it makes sense to include now, both for the benefits now and in the future.
There was a problem hiding this comment.
I think when brands are printed, it shows the structure, but nothing relevant about the brand. I can't visually distinguish 3 moola from 3 simloeans.
There was a problem hiding this comment.
Yes, that's right, but we are working on that. It doesn't make sense to take out logging of amounts, though, because as I mentioned, the values, if Nats, are still helpful. And, we are actively working on better printing of the brands.
There was a problem hiding this comment.
we are actively working on better printing of the brands.
Thanks, that's the clarification I was looking for.
packages/zoe/test/unitTests/contracts/test-secondPriceAuction.js
Outdated
Show resolved
Hide resolved
packages/zoe/test/unitTests/contracts/test-secondPriceAuction.js
Outdated
Show resolved
Hide resolved
| const assetWanted = bidSeat.getAmountAllocated('Asset', assetAtAuction.brand); | ||
| assert( | ||
| assetMath.isGTE(assetAtAuction, assetWanted), | ||
| details`more assets were wanted ${assetWanted} than were available ${assetAtAuction}`, |
There was a problem hiding this comment.
I think when brands are printed, it shows the structure, but nothing relevant about the brand. I can't visually distinguish 3 moola from 3 simloeans.
packages/zoe/test/unitTests/contracts/test-secondPriceAuction.js
Outdated
Show resolved
Hide resolved
packages/zoe/test/unitTests/contracts/test-secondPriceAuction.js
Outdated
Show resolved
Hide resolved
katelynsills
force-pushed
the
1482-auction
branch
from
52ae62f
to
2ee019e
Compare
katelynsills
force-pushed
the
1482-auction
branch
from
cf27fcb
to
55413f4
Compare
Closes #1482
The secondPriceAuction closes at the
closesAfterdeadline according to thetimerAuthority, both specified in the terms.