Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moddable e9742b49 2021-04-02 Merge #2796

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

dckc
Copy link
Member

@dckc dckc commented Apr 3, 2021

semi-automated; see #2648

@dckc dckc requested review from warner and michaelfig April 3, 2021 17:14
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck!

Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the only changes relevant to us are something in memory allocation. Seems good to me.

@michaelfig is the dapp-card-store CI failure a transient thing? It seems unrelated to this XS change.

@michaelfig
Copy link
Member

@michaelfig is the dapp-card-store CI failure a transient thing? It seems unrelated to this XS change.

See the following. Looks like an environment variable to set in the ci. I can't as I'm afk.

https://github.com/Agoric/agoric-sdk/pull/2796/checks?check_run_id=2260637819#step:11:33

@dckc dckc enabled auto-merge (rebase) April 5, 2021 15:53
@dckc dckc merged commit 95d010c into master Apr 6, 2021
@dckc dckc deleted the moddable-xs-update branch April 6, 2021 15:39
@dckc dckc restored the moddable-xs-update branch April 7, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants