Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable comms vat termination via remote comms errors #3024

Merged

Conversation

FUDCo
Copy link
Contributor

@FUDCo FUDCo commented May 4, 2021

Terrible hack to temporarily block errors processing remote comms messages from propagating upward (and thus killing the vat) and instead log them.

@FUDCo FUDCo added bug Something isn't working SwingSet package: SwingSet labels May 4, 2021
@FUDCo FUDCo requested a review from warner May 4, 2021 04:10
@FUDCo FUDCo self-assigned this May 4, 2021
@FUDCo FUDCo force-pushed the 3021-temporarily-suppress-comms-vat-asserts-in-deliver branch from e96fbec to 7521e16 Compare May 4, 2021 04:23
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sad to have to add this right now, but I reallly don't want the testnet comms vat to vanish because of external misbehavior. Looking forward to fixing it better next week.

@FUDCo FUDCo enabled auto-merge (rebase) May 4, 2021 04:37
@FUDCo FUDCo merged commit d286fbd into master May 4, 2021
@FUDCo FUDCo deleted the 3021-temporarily-suppress-comms-vat-asserts-in-deliver branch May 4, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SwingSet package: SwingSet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants