chore: change jsconfig.json includes, update packages, change swingset test #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
pushed a commit
that referenced
this pull request
Jun 15, 2021
Chris-Hibbert
pushed a commit
that referenced
this pull request
Jun 20, 2021
Chris-Hibbert
pushed a commit
that referenced
this pull request
Jun 21, 2021
Chris-Hibbert
added a commit
that referenced
this pull request
Jun 21, 2021
update testing imports for issue 768 add minimal types better fix for test dependencies change jsconfig.json includes, update packages, change swingset test (#3300) update committeeRegistrar for relocation of voterFacet integrate with changes to ballot PR (3233)
Chris-Hibbert
added a commit
that referenced
this pull request
Jun 21, 2021
update testing imports for issue 768 add minimal types better fix for test dependencies change jsconfig.json includes, update packages, change swingset test (#3300) update committeeRegistrar for relocation of voterFacet integrate with changes to ballot PR (3233)
Chris-Hibbert
added a commit
that referenced
this pull request
Jun 22, 2021
update testing imports for issue 768 add minimal types better fix for test dependencies change jsconfig.json includes, update packages, change swingset test (#3300) update committeeRegistrar for relocation of voterFacet integrate with changes to ballot PR (3233)
Chris-Hibbert
added a commit
that referenced
this pull request
Jun 23, 2021
update testing imports for issue 768 add minimal types better fix for test dependencies change jsconfig.json includes, update packages, change swingset test (#3300) update committeeRegistrar for relocation of voterFacet integrate with changes to ballot PR (3233)
Chris-Hibbert
added a commit
that referenced
this pull request
Jun 23, 2021
* feat: add a committeeRegistrar update testing imports for issue 768 add minimal types better fix for test dependencies change jsconfig.json includes, update packages, change swingset test (#3300) update committeeRegistrar for relocation of voterFacet integrate with changes to ballot PR (3233) * refactor: more legibility make ballotCounter instance accessible from ballot add more to terms of ballotCounter (closureRule) add more to public facet of Registrar one registrar per contract/vat: details in terms use zcf.getInstance() to supply instances In tests voters look up their own positions voters cast ballots on notification * refactor: closureRule renamed to closingRule * refactor: test and repair getOpenQuestions * chore: more cleanup * chore: review suggestions move some dependencies to devDependencies expect promises for ballots allow voters to cast directly with registrar * refactor: await all the promises, not just the last in a chain add a test for multiple votes by a single electorate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a linting issue