fix(swingset): make test-controller less sensitive to source changes #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
approved these changes
Aug 18, 2021
The kernel "activity hash" is sensitive to everything written into the kvstore, including the bundled sources of built-in vats (like comms and vatAdmin), which include upstream libraries like marshal and assert. This makes the hash sensitive to a significant amount of code, and test-controller was asserting a specific value. This required updating the test's expectations on every code changes. Instead, we now merely check that `controller.getActivityhash()` returns a correctly-shaped string, instead of examining the actual value. closes #3718
warner
force-pushed
the
3718-downgrade-hash-test
branch
from
de17c54
to
6c0f319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel "activity hash" is sensitive to everything written into the
kvstore, including the bundled sources of built-in vats (like comms and
vatAdmin), which include upstream libraries like marshal and assert. This
makes the hash sensitive to a significant amount of code, and test-controller
was asserting a specific value. This required updating the test's
expectations on every code changes.
Instead, we now merely check that
controller.getActivityhash()returns acorrectly-shaped string, instead of examining the actual value.
closes #3718