fix(cosmos): ensure simulated transactions can't trigger SwingSet #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-3739-simulated-txes
branch
from
9ccd635
to
c8eb958
Compare
The former pattern of `vm.IsSimulation` was too brittle to handle our migration to the GRPC-based transaction handlers. Instead, intercept the actual invocation of CallToController and prevent it from running anything in SwingSet if in simulation mode. Also, make sure our InfiniteGasMeter is only assigned once, so that if we ever do Cosmos-level metering of SwingSet downcalls, there is only one place to adjust.
michaelfig
force-pushed
the
mfig-3739-simulated-txes
branch
from
c8eb958
to
997329a
Compare
dckc
reviewed
Aug 21, 2021
michaelfig
added a commit
that referenced
this pull request
Aug 21, 2021
fix(cosmos): ensure simulated transactions can't trigger SwingSet
JimLarson
reviewed
Aug 21, 2021
| @@ -23,7 +23,7 @@ func NewStorageHandler(keeper Keeper) storageHandler { | |||
| return storageHandler{keeper: keeper} | |||
| } | |||
|
|
|||
| func (sh storageHandler) Receive(ctx *vm.ControllerContext, str string) (ret string, err error) { | |||
| func (sh storageHandler) Receive(cctx *vm.ControllerContext, str string) (ret string, err error) { | |||
There was a problem hiding this comment.
I've been using ctlCtx, e.g. in vbank_test.go, so we should use one of the two names consistently (I don't care which). Might save some clutter below by extracting ctx := ctlCtx.Context at the top.
| callToController := func(ctx sdk.Context, str, simReturn string) (string, error) { | ||
| if vm.IsSimulation(ctx) { | ||
| // Just return the simReturn, since the message is being simulated. | ||
| return simReturn, nil |
There was a problem hiding this comment.
It sure looks like simReturn is always the empty string. If so, you can avoid the extra arg to callToController and avoid a lot of changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3739
The former pattern of
vm.IsSimulationwas too brittle to handleour migration to the GRPC-based transaction handlers. Instead,
intercept the actual invocation of CallToController and prevent
it from running anything in SwingSet if in simulation mode.
Also, make sure our InfiniteGasMeter is only assigned once, so
that if we ever do Cosmos-level metering of SwingSet downcalls,
there is only one place to adjust.