Update docker-compose instructions

[mhofman]

refs: #4072

Description

The docker-compose.yml file was stuck in time and no longer matched the instructions.

We probably could have a script to update the default version to a specific tag when publishing devnet, but in the meantime, require user to be explicit. The netconfig is also made explicit.

I did not update the AG_SOLO_BASEDIR environment, not sure if that's necessary, but it doesn't match the published https://beta.agoric.net/docker-compose.yml

Security Considerations

N/A

Documentation Considerations

None.

Testing Considerations

This is not part of CI, and I'm not sure how it could be. The change is pretty trivial however.

[michaelfig]

This is a good change, and you've pinpointed the needs to update it.

Fwiw, the instructions should point to download the appropriate yml from agoric.net, or at least to set NETCONFIG_URL to the correct location. Maybe it should not default?

[mhofman]

the instructions should point to download the appropriate yml from agoric.net

The instructions do already point to beta.agoric.net, but not everyone seem to read through the instructions ;)

[mhofman]

at least to set NETCONFIG_URL to the correct location. Maybe it should not default?

If we can find a way to make it obvious the github hosted file should be edited, removing the default probably is the best approach?

[michaelfig]

at least to set NETCONFIG_URL to the correct location. Maybe it should not default?

If we can find a way to make it obvious the github hosted file should be edited, removing the default probably is the best approach?

The best I could find was just:

diff --git a/docker/README.md b/docker/README.md
index fd2d9c763..e34c6a68c 100644
--- a/docker/README.md
+++ b/docker/README.md
@@ -2,7 +2,7 @@
 
 ## Quick Start (Overview)
 
- 1. Start the `ag-solo` service: `docker-compose up -d`
+ 1. Start the `ag-solo` service on `devnet`: `NETCONFIG_URL=https://devnet.agoric.net/network-config docker-compose up -d`
  2. Watch the logs for registration details: `docker-compose logs -f --tail=50`
  3. Issue an unguessable URL to the wallet: `docker-compose exec ag-solo agoric open --repl`
 
diff --git a/docker/docker-compose.yml b/docker/docker-compose.yml
index 529a92000..7ff74cc99 100644
--- a/docker/docker-compose.yml
+++ b/docker/docker-compose.yml
@@ -16,6 +16,8 @@ services:
       - setup
       - --webhost=0.0.0.0
       - --webport=${PORT:-8000}
-      - --netconfig=${NETCONFIG_URL:-https://devnet.agoric.net/network-config}
+      # NOTE: Use an environment variable like:
+      #   NETCONFIG_URL=https://devnet.agoric.net/network-config
+      - --netconfig=${NETCONFIG_URL}
 volumes:
   ag-solo-state:

If you don't have time for this or feel it might be misleading, please land without. I'm fine with this PR either way.

[mhofman]

Should the SDK_TAG not default to anything either then ?

[michaelfig]

Should the SDK_TAG not default to anything either then ?

Yes, it probably shouldn't default also.

[mhofman]

I ended up doing a little more heavy editing of the Readme. PTAL @michaelfig

[michaelfig]

LGTM. Well done!