Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to Cosmos SDK v0.44.0-alpha.agoric.1 #4131

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Nov 27, 2021

Description

Upgrades to new Cosmos SDK+Agoric patches.

Also, in the ongoing battle against nondeterminism, crash cosmic-swingset if there are actions left over from a previous block. That should never happen, and was an indication a while ago that we were accidentally sending simulated transactions to SwingSet.

Security Considerations

Documentation Considerations

Testing Considerations

@michaelfig michaelfig added tooling repo-wide infrastructure agd Agoric (Golang) Daemon labels Nov 27, 2021
@michaelfig michaelfig self-assigned this Nov 27, 2021
@michaelfig michaelfig marked this pull request as draft November 27, 2021 04:48
@michaelfig michaelfig force-pushed the mfig-prepare-chain branch 9 times, most recently from bad3760 to 4310049 Compare November 27, 2021 06:03
@michaelfig michaelfig removed the tooling repo-wide infrastructure label Nov 27, 2021
Copy link
Contributor

@JimLarson JimLarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go stuff looks good. You might want another reviewer to cover the JS files.

@michaelfig michaelfig marked this pull request as ready for review November 30, 2021 21:58
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion and one question; neither is critical

packages/cosmic-swingset/src/block-manager.js Outdated Show resolved Hide resolved
decohered = Error(
`Block ${action.blockHeight} begun with leftover uncommitted actions: ${leftover}`,
);
throw decohered;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this crash before the bad state gets committed or after? I think either design is acceptable, but I'd like to know which we're aiming at. Before is better, but it's still bad...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulation happens between blocks. So, it crashes before since no simulated transactions have yet been sent up to SwingSet before this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agd Agoric (Golang) Daemon automerge:no-update (expert!) Automatically merge without updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants