fix(vats)!: migrate to use @agoric/far, remove deprecated REPL code
#4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
changed the title
@agoric/far@agoric/far, remove deprecated REPL code
dckc
reviewed
Dec 2, 2021
packages/vats/src/virtual-purse.js
Outdated
Comment on lines
11
to
13
| * @typedef {import('@agoric/far').EOnly<T>} EOnly An object roughly of type T | ||
| * that is only allowed to be consumed via eventual-send. This allows the | ||
| * object to return Promises wherever it wants to, even when T demands a |
There was a problem hiding this comment.
any particular reason to duplicate this documentation here?
There was a problem hiding this comment.
Not really. I've removed this comment in favour of just a bare @typedef.
michaelfig
force-pushed
the
mfig-demonstrate-agoric-far
branch
from
2044645
to
d96c217
Compare
michaelfig
force-pushed
the
mfig-demonstrate-agoric-far
branch
from
d96c217
to
3f41296
Compare
|
To do this migration, replace all possible instances of If |
dckc
approved these changes
Dec 2, 2021
michaelfig
added
the
automerge:no-update
This was referenced Oct 21, 2022
This was referenced Oct 21, 2022
This was referenced Oct 21, 2022
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#122
Open
This was referenced Oct 21, 2022
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#126
Open
This was referenced Oct 22, 2022
This was referenced Oct 22, 2022
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#131
Open
This was referenced Oct 22, 2022
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#138
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#139
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#141
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#142
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#143
Open
This was referenced Feb 2, 2024
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#253
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#255
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#257
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#259
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#260
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#261
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#262
Open
[Snyk] Security upgrade @agoric/install-ses from 0.3.3-dev.0 to 0.5.29
Kashuhackerone/agoric-sdk#263
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #4144
Description
Show how to use
@agoric/farin client code, namely thepackages/vatspackage.While we're there, remove the long-deprecated
ui-agentcode from the REPL, and endow exports from@agoric/far.Security Considerations
Documentation Considerations
The
ui-agentwas an undocumented feature, and not used except for an ancient repl demo (since rewritten) a long time ago.Testing Considerations