Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reenable workflows that rely on pushes to $default-branch #4146

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

michaelfig
Copy link
Member

Description

The $default-branch macro is not expanded in .github/workflows, only
workflow-templates. So, unfortunately, we have to hardcode the
master branch in the yml files to get these to work.

Security Considerations

Documentation Considerations

Testing Considerations

@michaelfig michaelfig requested a review from dckc December 2, 2021 18:49
@michaelfig michaelfig self-assigned this Dec 2, 2021
@michaelfig michaelfig added the tooling repo-wide infrastructure label Dec 2, 2021
pull_request:
branches: [$default-branch]
push:
branches: [ master ] # $default-branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to keep $default-branch in a comment so that searches find it.

@michaelfig michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Dec 2, 2021
The `$default-branch` macro is not expanded in workflows, only
workflow-templates.  So, unfortunately, we have to hardcode the
`master` branch in the `yml` file to get these to work.
@mergify mergify bot merged commit 8002489 into master Dec 2, 2021
@mergify mergify bot deleted the mfig-workflow-default-branch branch December 2, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates tooling repo-wide infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants