Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seat isolation #4316

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Fix seat isolation #4316

merged 2 commits into from
Jan 19, 2022

Conversation

erights
Copy link
Member

@erights erights commented Jan 18, 2022

Fixes #4298

@erights erights self-assigned this Jan 18, 2022
@erights erights requested a review from dtribble January 18, 2022 01:24
@erights erights added the audit-zestival Vulnerability assessment of ERTP + Zoe label Jan 18, 2022
erights
erights commented Jan 18, 2022
View reviewed changes
Copy link
Member Author

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must add a test sensitive to the difference

@erights erights force-pushed the 4298-markm-fix-seat-isolation branch from 0a7bc9f to 20b354a Compare January 18, 2022 21:03
@erights
Copy link
Member Author

erights commented Jan 18, 2022

I must add a test sensitive to the difference

Turns out there was a test sensitive to the difference, which CI caught. I didn't see it locally when I wrote the above comment because I forgot to yarn build first.

In any case, I repurposed the test by flipping it to t.notThrows. This is now R4R and a candidate for merging.

@erights erights force-pushed the 4298-markm-fix-seat-isolation branch from 20b354a to ef1c5fb Compare January 19, 2022 02:37
dtribble
dtribble approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@dtribble dtribble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this fixes the problem.

It slightly exacerbates other staging problems (where the outstanding other changes could overlap with the stagings in the current reallocate), but those already existss.

@erights erights merged commit 7b8d7fe into master Jan 19, 2022
@erights erights deleted the 4298-markm-fix-seat-isolation branch January 19, 2022 17:31
@erights erights mentioned this pull request Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtribble dtribble dtribble approved these changes

Assignees

@erights erights

Labels
audit-zestival Vulnerability assessment of ERTP + Zoe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seat staging can break isolation of across zcfSeats
2 participants
@erights @dtribble