fix: test/comment improvements from vault restival review #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Mar 10, 2022
| { | ||
| message: 'Transfer during vault adjustment', | ||
| }, | ||
| 'adjust balances should have been rejected', |
| @@ -636,6 +637,7 @@ export const makeInnerVault = ( | |||
| updateUiState(); | |||
| clientSeat.exit(); | |||
|
|
|||
| // TODO get rid of strings? | |||
There was a problem hiding this comment.
if you happen to make another commit on this branch, this could be a good issue for the TODO #4360
* added test for reallocate with unstaged seat * vault comment improvements * improved error verification in tests
dtribble
force-pushed
the
vault_comments
branch
from
5f8415b
to
6446814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chore: improvements from restival review
Security Considerations
None
Documentation Considerations
Improves internal documentation
Testing Considerations
None. Normal CI executes the additional tests.
refs: #4804