-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support publishing source bundles to chain and installing hash bundles to Zoe #4975
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f5d53ec
fix(solo): Portable file path to URL in start
kriskowal 08368d4
fix(solo): Portable file path to URL in chain-cosmos-sdk
kriskowal 01cdbc9
feat(solo): Add /connections and /install-bundle HTTP routes
kriskowal 3fded16
refactor(solo): Remove superfluous bundle preinit
kriskowal ea3a1bf
fix(solo): Add missing extension to test-env import
kriskowal 616f26e
fix(solo): Relax extraneous xsnap dependency
kriskowal 9d2788d
fix(agoric-cli): Portable file path to URL in deploy
kriskowal 69647a2
feat(agoric-cli): Inject publishBundle and listConnections to deploy …
kriskowal d6062eb
fixup remove publish-bundle
kriskowal 2d11fde
feat(golang/cosmos): Add InstallBundle RPC message types to Protobuf …
kriskowal b69b94f
feat(golang/cosmos): Implement SDK InstallBundle message type
kriskowal e3ae969
feat(cosmic-swingset): Handle InstallBundle messages
kriskowal 6d3e227
feat(agd): Add install-bundle command
kriskowal 815c035
fix(zoe): Note #4974 subsume installBundleID in install
kriskowal 8f9ad75
feat(zoe): Support installation of hash bundles
kriskowal 99c6931
chore: Sync Endo versions
kriskowal 90c545f
chore: Update yarn.lock
kriskowal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing it's not sufficiently convenient+useful to check e.g. JSON-shape, expected keys, base64-ness, or deeper?
I suppose the only benefit of additional checks would be that I might pay for an installation of something bogus, and get it into a block, only to get rejected after that block was executed by validators.
Eventually I think we want to do more extensive checks here to prevent abuse of blocks as a storage mechanism, catch the misshapen junk before it can get added to a block or flooded to all nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe keeping the bundle format opaque at this layer keeps with the spirit of Michael’s intention for the type to evolve freely.