feat: separate genesis from RUN protocol installation #5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
dc-boot-from-installation
branch
from
05c763f
to
b82d804
Compare
michaelfig
force-pushed
the
dc-boot-from-installation
branch
2 times, most recently
from
3ca0cf9
to
83a19d7
Compare
to let swingset-core-eval proposals refer to module code via installations
- centralSupply, mintHolder contracts
- core/boot.js: no more roleToGovernanceActions - TODO: restore vaults, AMM etc. on sim chain - more bundles -> installations (manifest, ...)
- makeBundle -> provideBundle, with caching
michaelfig
force-pushed
the
dc-boot-from-installation
branch
from
9e47fe6
to
03270fe
Compare
michaelfig
force-pushed
the
dc-boot-from-installation
branch
from
03270fe
to
125e9ba
Compare
michaelfig
added
cosmic-swingset
This was referenced Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #5029
Description
The bootstrap behaviors in
@agoric/run-protocolassumed that deployment and genesis were the same time.This PR clearly separates genesis bootstrap from later governance actions where RUN protocol contracts are given access to bootstrap powers such as the RUN mint.
It should also facilitate using modules in swingset-core-eval proposals by making more use of installations and less bundles.
Meanwhile, I reached my tolerance for waiting for bundling over and over, so this PR also includes a prototype of bundle caching (#3609).
Security Considerations
This change should continue to separate production mode from demo, but as there are high-power authorities in play, careful review is in order.
Documentation Considerations
It's not clear that the sim chain survives this change in tact. We may need to notify devs to stand by until we get that part put back together.
The plan is to make a separate bootstrap vat, further separating demo / simulation mode from production mode. The RUN protocol contract bundles may be present in the sim bootstrap vat, but not in production.
IOU issues for:
bundleTool.jshere andtool.jsin@endo/bundle-source(noted in prototype caching/construction of bundles on filesystem #3609 (comment) )The convention for paths for contract bundle roots changes to package-relative.
Testing Considerations
Restoring previous tests to working order is the goal of this PR.
Some other kicking the tires is in order before the upcoming devnet launch (#5049). Ideally we'll develop some integration tests for launching RUN protocol by cosmos governance.