feat(run-protocol): preview launch support, PSM work-around #5215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
dckc
force-pushed
the
dc-psm-gov-workaround
branch
from
a1cc82f
to
0c09439
Compare
Closed
dckc
force-pushed
the
dc-psm-gov-workaround
branch
from
0c09439
to
907dae1
Compare
along with makeAnchorAsset
- use mintHolder for psm anchor asset
to avoid including makeIssuerKit in a core eval script
- startPSM: include Electorate in terms
- RATIO params
Maintain E(home.scratch).get('installCache')
as a CopyMap<Hash,
{
sha512: string,
installation: Installation,
path?: string
}>
Also, save installCache in the board.
It turns out that we can't put a copyMap in the board; so we get a
boardId for each installation, JSON.stringify the mapping of sha512 to
boardId, and put that in the board.
- CHAIN_OPTS for local-chain, agoricstage, ... - shell quoting for description - clean-core-eval no longer needed
- look up PSM installations by hash - eslint-happy output - each install is on the board - merge permits with --permit fixup: declare BASIS_POINTS too fixup: writePsmScript produceIt
generated using:
yarn deploy:contracts
...
{ boardId: 'board04827' }
INSTALL_CACHE=board04827 \
ANCHOR_DENOM=ibc/949E954E05CE9E63E072ABD13A7DAAAB338A1E57FFBC148C50D74451AB5067D1 \
yarn build:eval-code:psm
yarn build:eval-permit:psm
dckc
force-pushed
the
dc-psm-gov-workaround
branch
from
907dae1
to
3742b1a
Compare
michaelfig
approved these changes
Apr 25, 2022
michaelfig
reviewed
Apr 25, 2022
| @@ -74,7 +73,7 @@ export const startEconomicCommittee = async ( | |||
| }, | |||
| electorateTerms = { | |||
| committeeName: 'Initial Economic Committee', | |||
| committeeSize: 1, | |||
| committeeSize: 3, | |||
There was a problem hiding this comment.
This apparently causes a failure at https://github.com/Agoric/agoric-sdk/runs/6167083776?check_suite_focus=true#step:5:9111
dckc
force-pushed
the
dc-psm-gov-workaround
branch
from
3742b1a
to
6616d86
Compare
turadg
approved these changes
Apr 25, 2022
| @@ -10,7 +10,10 @@ | |||
| "scripts": { | |||
| "build": "yarn build:bundles", | |||
There was a problem hiding this comment.
Should this build * like 'lint' does?
There was a problem hiding this comment.
perhaps... but some of the build:* things involve blockchain access, so they don't fit the same workflow.
dckc
force-pushed
the
dc-psm-gov-workaround
branch
from
6616d86
to
6f83843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #5062
closes: #5010
modulo #5218
Description
This is the work necessary to get a clean preview deploy in agoricstage-23.
These are not work-arounds, so they should land:
These are the PSM work-around for version skew with agoricdev-10. Let's land these for the short term; #5218 represents work to clean them up:
This is a generated artifact; I kept it checked in so that I could track how it was changing.
Security Considerations
Documentation Considerations
Testing Considerations