Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add API for configuring kernel & vat options on a running swingset #5510

Merged
merged 1 commit into from
Jun 10, 2022
Merged

feat: add API for configuring kernel & vat options on a running swingset #5510

merged 1 commit into from
Jun 10, 2022

Conversation

FUDCo
Copy link
Contributor

@FUDCo FUDCo commented Jun 4, 2022

Fixes #5237

Adds a changeOptions call the vat admin node API and a changeKernelOptions call to the controller API.

@FUDCo FUDCo added enhancement New feature or request SwingSet package: SwingSet labels Jun 4, 2022
@FUDCo FUDCo requested a review from warner June 4, 2022 01:38
@FUDCo FUDCo self-assigned this Jun 4, 2022
@FUDCo FUDCo force-pushed the 5237-parameter-configuration branch from dae1f0e to 0be3047 Compare June 4, 2022 01:43
warner
warner requested changes Jun 7, 2022
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small, some medium changes to make

packages/SwingSet/src/controller/controller.js Show resolved Hide resolved
packages/SwingSet/src/kernel/kernel.js Show resolved Hide resolved
packages/SwingSet/src/vats/vat-admin/vat-vat-admin.js Show resolved Hide resolved
packages/SwingSet/src/devices/vat-admin/device-vat-admin.js Show resolved Hide resolved
packages/SwingSet/src/kernel/state/kernelKeeper.js Show resolved Hide resolved
packages/SwingSet/src/kernel/kernel.js Outdated Show resolved Hide resolved
packages/SwingSet/src/kernel/vat-admin-hooks.js Show resolved Hide resolved
packages/SwingSet/src/liveslots/liveslots.js Show resolved Hide resolved
packages/SwingSet/test/change-parameters/bootstrap-change-parameters.js Outdated Show resolved Hide resolved
packages/SwingSet/test/change-parameters/vat-carol.js Outdated Show resolved Hide resolved
@FUDCo FUDCo force-pushed the 5237-parameter-configuration branch from 0be3047 to 8c77736 Compare June 9, 2022 01:33
@FUDCo FUDCo requested a review from warner June 9, 2022 01:33
warner
warner approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some cosmetic changes to make, then feel free to land

packages/SwingSet/docs/configuration.md Outdated Show resolved Hide resolved
packages/SwingSet/docs/configuration.md Show resolved Hide resolved
packages/SwingSet/docs/configuration.md Show resolved Hide resolved
packages/SwingSet/src/kernel/kernel.js Show resolved Hide resolved
packages/SwingSet/src/kernel/state/kernelKeeper.js Show resolved Hide resolved
packages/SwingSet/src/kernel/vat-admin-hooks.js Show resolved Hide resolved
packages/SwingSet/src/vats/vat-admin/vat-vat-admin.js Show resolved Hide resolved
@FUDCo FUDCo force-pushed the 5237-parameter-configuration branch from 8c77736 to 14072a3 Compare June 10, 2022 00:37
@FUDCo FUDCo added the automerge:rebase Automatically rebase updates, then merge label Jun 10, 2022
@mergify mergify bot merged commit 8770b12 into master Jun 10, 2022
@mergify mergify bot deleted the 5237-parameter-configuration branch June 10, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warner warner warner approved these changes

Assignees

@FUDCo FUDCo

Labels
automerge:rebase Automatically rebase updates, then merge enhancement New feature or request SwingSet package: SwingSet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kernel parameter configuration API and chain-side controls
2 participants
@FUDCo @warner