fix(swingset): remove xs-worker-no-gc and gcEveryCrank #5707
+12
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
5600-remove-xs-worker-no-gc
branch
4 times, most recently
from
21799ce
to
c09b6d6
Compare
While we were debugging performance problems last year, we introduced `managerType: 'xs-worker-no-gc'`, which is a variant of `xs-worker` that disables the forced GC we were doing at the end of every delivery. Since then, we've improved performance in several ways: * XS bugs were retaining objects, which have since been fixed * we only do a forced GC during special `dispatch.bringOutYourDead` cranks * we deliver BOYD less often (according to a configurable schedule, see #4160 for our decisions, but we're thinking once every 100 to 1000 deliveries) The `xs-worker-no-gc` manager type controlled a flag named `gcEveryCrank`, which replaced the GC primitive available to liveslots with a dummy version. This commit removes both `xs-worker-no-gc` and `gcEveryCrank`. closes #5600
warner
force-pushed
the
5600-remove-xs-worker-no-gc
branch
from
c09b6d6
to
b3c7c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we were debugging performance problems last year, we introduced
managerType: 'xs-worker-no-gc', which is a variant ofxs-workerthat disables the forced GC we were doing at the end of every
delivery.
Since then, we've improved performance in several ways:
dispatch.bringOutYourDeadcranks
see Performance impact of BOYD #4160 for our decisions, but we're thinking once every 100 to 1000
deliveries)
The
xs-worker-no-gcmanager type controlled a flag namedgcEveryCrank, which replaced the GC primitive available to liveslotswith a dummy version.
This commit removes both
xs-worker-no-gcandgcEveryCrank.closes #5600