4383 durable zoe #5879
Merged
4383 durable zoe #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
Zoe
Chris-Hibbert
force-pushed
the
4383-durableZoe
branch
from
4a35fdd
to
4d4b514
Compare
erights
approved these changes
Aug 4, 2022
| * @param {ShutdownWithFailure | undefined} shutdownZoeVat | ||
| */ | ||
| export const createInvitationKit = (shutdownZoeVat = undefined) => { | ||
| const invitationKit = makeIssuerKit( | ||
| export const createInvitationKit = (baggage, shutdownZoeVat = undefined) => { |
There was a problem hiding this comment.
What do you think of a naming convention where functions that
- take a baggage first argument,
- call a
vivifySomething - therefore need to be called during the first crank, if they might be revivifying
should themselves be called vivifySomething?
Suggested change
| export const createInvitationKit = (baggage, shutdownZoeVat = undefined) => { | |
| export const vivifyInvitationKit = (baggage, shutdownZoeVat = undefined) => { |
There was a problem hiding this comment.
sounds like a good rule.
Chris-Hibbert
force-pushed
the
4383-durableZoe
branch
from
4d4b514
to
917e1cd
Compare
Chris-Hibbert
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #4383
Description
First step of making Zoe reachably durable. This covers all of Zoe's global state. Remaining tasks are
I recommend reviewing this by commits. The commits separately update InvitationIssuer, escrow storage, installationStorage, and proposalSchema storage.
Security Considerations
Maintain Zoe invariants
Documentation Considerations
None.
Testing Considerations
Ensure existing tests continue to pass.