feat: distribute PSM Charter Invitatitons #6166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
enhancement
dckc
approved these changes
Sep 8, 2022
| invitationP, | ||
| E(creatorFacet).makeCharterMemberInvitation(), | ||
| ]); | ||
| console.log('@@@sending charter, voting invitations to', addr); |
There was a problem hiding this comment.
Suggested change
| console.log('@@@sending charter, voting invitations to', addr); | |
| console.log('sending charter, voting invitations to', addr); |
That @@@ thingy is my "I have to run to a meeting now; make sure I don't ship this half-baked code" marker. Let's take it out. Or we can drop the log message altogether, but I think maybe this is worth keeping.
| addr, | ||
| [voterInvitation, charterMemberInvitation], | ||
| ); | ||
| console.log('@@@sent charter, voting invitations to', addr); |
There was a problem hiding this comment.
Suggested change
| console.log('@@@sent charter, voting invitations to', addr); | |
| console.log('sent charter, voting invitations to', addr); |
| }, | ||
| }, | ||
| }), | ||
| invitePSMCommitteeMembers(powersFor('invitePSMCommitteeMembers'), { |
Chris-Hibbert
force-pushed
the
6110-charterInvitations
branch
from
3b8e7f3
to
541e027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6110
Description
Distribute PSM Charter invitations to committee members in bootstrap
Security Considerations
The Charter, and the ability to instigate votes, should only be accessible to members of the committee.
Documentation Considerations
[Eventually] we should write up how governance works through the smartWallet. This is a small aspect of that.
Testing Considerations
A manual End-2-End is coming shortly.