test: updated test cases from test-vaultFactory.js #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not presently. See #6811 (comment) |
|
Thanks for your contribution, @tgrecojs! Sorry it languished. Do we need something like this PR yet? If not, let's close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: updated some of the test cases from test-vaultFactory to use the correct API
refs: #6811
Description
WIP PR for updating vault code to use the correct invitations. If this is desired, then I believe the plan of action would be to continue through the tests to make sure they are no longer using the deprecated
makeVaultInviation.Security Considerations
Not AFAIK, but I could be overlooking something.
Documentation Considerations
Testing Considerations
I don't believe any additional test cases are needed. Just need to make sure all existing tests are passing once the code is updated.