Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move allValues, zip to internal #7075

Merged
merged 5 commits into from
Feb 25, 2023
Merged

refactor: move allValues, zip to internal #7075

merged 5 commits into from
Feb 25, 2023

Conversation

dckc
Copy link
Member

@dckc dckc commented Feb 24, 2023

refs: #7049
(tangentially related)

Description

  • move allValues, zip to @agoric/internal
    • prune inter-protocol/src/collect.js
  • split internal/src/utils.js between Jessie and extra-Jessie

Security/Scaling/Documentation/Testing Considerations

none; pure refactor

@dckc dckc requested a review from turadg February 24, 2023 23:43
turadg
turadg approved these changes Feb 24, 2023
View reviewed changes
packages/internal/src/method-tools.js Outdated Show resolved Hide resolved
@dckc @turadg
docs: clarify not Jessie
73e27d1 
Co-authored-by: Turadg Aleahmad <[email protected]>
@dckc dckc added the automerge:squash Automatically squash merge label Feb 25, 2023
@mhofman mhofman removed the automerge:squash Automatically squash merge label Feb 25, 2023
@mhofman mhofman added the automerge:squash Automatically squash merge label Feb 25, 2023
@mergify mergify bot merged commit b71d61c into master Feb 25, 2023
@mergify mergify bot deleted the dc-collect-internal branch February 25, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

Assignees
No one assigned
Labels
automerge:squash Automatically squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dckc @turadg @mhofman