feat(SwingSet): loadSwingsetConfigFile detects missing files #7076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than the mysterious: SwingSet: xsnap: v1: Error#1: Archive failed sanity check: should contain at least a compartment map file and one module file in <unknown> fail early with: Error#1: spec for @agoric/vats/src/core/boot.js does not exist: /.../agoric-sdk/packages/solo/@agoric/vats/src/core/boot.js
turadg
approved these changes
Feb 25, 2023
warner
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Sounds like a great fix to me.
Also note endojs/endo#1206 which is about Endo (bundleSource) noticing this properly too. No reason to not do a pre-check, of course.
|
the commit here landed in master 64a3baa leaving this PR open in case there are more diagnostics coming |
|
perhaps I'll re-open another time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #7049, #6687
part of #7049
Description
rather than running for 20 seconds and failing with the mysterious:
fail early with:
Security Considerations
In its current state, this digs the ambient authority hole (#2160) a little deeper. Depending on feedback about whether this is wanted, I could clean that up.
Testing Considerations
makes testing bootstrap quite a bit faster