fix: agops: no I/O (errors) until command action

[dckc]

refs: #6930
factoring out of #7256

Description

Each of commands/oracle.js, commands/ec.js etc. was calling makeRpcUtils on module import. Not only did this slow things down, it made catching I/O errors in the agops inter command infeasible.

Scaling Considerations

about 20 fewer RPC requests per agops command.

Security, Documentation Considerations

Not much... perhaps nicer diagnostics for agops inter is documentation.

Testing Considerations

no change in the (lack of) automated testing

[turadg]

Some cleanup suggested by not required. There are lint violations but I'll leave that between you and CI.

[turadg]

ah yes. I think this was made one in rpc.js before but that was bad so it was factored it into a maker, but then didn't go the distance to only make where used.

[turadg]

consider letting the object pass through,

Suggested change

	const { agoricNames, fromBoard, vstorage } = await makeRpcUtils({ fetch });
	const utils = await makeRpcUtils({ fetch });

and then,

const instance = utils.agoricNames.instance[name];
…
return {...utils, lookupPriceAggregatorInstance};

[turadg]

ditto with comment above. if we do this often maybe worth another argument to makeRpcUtils that takes a maker for more utils.

const rpcTools = () => return makeRpcUtils(
  {fetch}, 
  base => {
    lookupPsmInstance: ([minted, anchor]) => {
      const name = `psm-${minted}-${anchor}`;
      const instance = base.agoricNames.instance[name];
      if (!instance) {
        logger.debug('known instances:', agoricNames.instance);
        throw new Error(`Unknown instance ${name}`);
      }
      return instance;
    }

[dckc]

I usually go for the objects as closures pattern...

const makeThing = powers => {
  ...
  return harden({ method1, method2, ... });l
}

... and think about POLA while I'm at it. The bundles of rights that come to mind are:

• an RPC client, including vstorage. it would know about network-config and ideally do failover
• such a client that also has fromBoard state and knows about board marshalling
• keyring access: just map names to addresses, no private key access
• keyring+RPC: a sign-and-broadcast tool