Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zoe): error on unexpected properties from start() #7421

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Apr 14, 2023

Description

A bit of hygiene in case a contract author accidentally returns other facets. For example, if they made a durable object with a helper facet and returned the whole object as the start result.

Security Considerations

Reduces chances of errantly returning extra capabilities.

Scaling Considerations

Documentation Considerations

Testing Considerations

new test

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Apr 15, 2023
@turadg
Copy link
Member Author

turadg commented Apr 15, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2023

refresh

✅ Pull request refreshed

@turadg turadg force-pushed the ta/validate-contract-facets branch from 90332e9 to 807d175 Compare April 15, 2023 01:36
@mergify mergify bot merged commit 4eb322b into master Apr 15, 2023
@mergify mergify bot deleted the ta/validate-contract-facets branch April 15, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants