Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce imports of @agoric/store #7949
base: master
Are you sure you want to change the base?
reduce imports of @agoric/store #7949
Changes from all commits
6e61498
d8e191d
9aeee65
6b1630b
d6f484f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC the purpose of this PR, I'd expect you to prefer to import
makeScalarMapStore
from@agoric/store
, where it originates, rather than@agoric/vat-data
which imports and re-exports it. This seems more consistent with your preference (which I share) to import, for example,makeExo
from@endo/exo
where it originates, rather than@agoric/store
, which imports and re-exports it.Likewise for other similar changes from
@agoric/store
to@agoric/vat-data
below.FWIW, I plan to migrate
@agoric/store
to become@endo/store
, and to move most of@agoric/zone
to@endo/zone
. Longer term, I expect such manual use ofmakeExo
andmakeScalarMapStore
to migrate to using the corresponding Zone APIs. Just FYI; doesn't affect this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I mistakenly had in mind that
vat-data
sourced the functionality fromglobalThis
and thus didn't entail a package dependency on@agoric/store
.I'll revert the changes that preferred vat-data.