feat(vat-data): virtual exos are internally revocable #8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
changed the title
erights
force-pushed
the
markm-internal-revocables
branch
from
cdf3450
to
b38139b
Compare
erights
commented
Jul 6, 2023
| @@ -920,15 +920,25 @@ export const makeVirtualObjectManager = ( | |||
| const makeContext = (baseRef, state) => { | |||
| // baseRef came from valToSlot, so must be in slotToVal | |||
| const val = requiredValForSlot(baseRef); | |||
| const revoke = () => contextCache.delete(baseRef); | |||
There was a problem hiding this comment.
@FUDCo do I need to register this object for some internal gc purpose? Does it being a function raise any additional issues?
|
Reversed decision. Now closing in favor of #8020 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #8020 with internal revocability
Extracted from Spike at #8009 because it is already mergeable without #8009's other support
Mirrors endojs/endo#1668 but does not depend on it.