fix(vibc): accommodate ibc-go v3 breaking changes #8127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelfig This works like a charm! Manually tested |
michaelfig
force-pushed
the
mfig-vibc-write-open-init
branch
from
4cecf78
to
41be8f4
Compare
This was referenced Aug 2, 2023
JimLarson
approved these changes
Aug 3, 2023
michaelfig
force-pushed
the
mfig-vibc-write-open-init
branch
from
504286f
to
76bdc3f
Compare
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
fix(vibc): accommodate ibc-go v3 breaking changes
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
fix(vibc): accommodate ibc-go v3 breaking changes
mhofman
pushed a commit
that referenced
this pull request
Nov 8, 2023
fix(vibc): accommodate ibc-go v3 breaking changes
mhofman
pushed a commit
that referenced
this pull request
Nov 10, 2023
fix(vibc): accommodate ibc-go v3 breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@schnetzlerjoe reported that outbound dibc channels were not modifying the chain's channel state. We traced this down to a breaking change in ibc-go v3.
This PR uses a helper function available in ibc-go v3 to write channel state and emit events. We can also remove our hackish workaround to emit relayer-compatible events.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
Manually tested with a dibc contract. We really need to make tests using the IBC Testing Framework.
Upgrade Considerations
n/a