lint-with-types cleanup #8236
Merged
lint-with-types cleanup #8236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
approved these changes
Aug 22, 2023
| # all scopes | ||
| yarn lint | ||
| echo "The regular lint command now lints with types. Just use that." | ||
| exit 0 |
There was a problem hiding this comment.
Should we exit 1 here, and echo to stderr ?
There was a problem hiding this comment.
I did mean to exit 1. nbd tho, this script was used only by CI and it's going away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 10min timeout for the lint job is exceed sometimes since #8198
(example)
This raises it to 15min and cleans up the config options.