build(golang): Support faster local iteration and align better with upstream #8840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimLarson
approved these changes
Jan 30, 2024
Comment on lines
-80
to
-82
| go-mod-cache: go.sum | ||
| @echo "--> Download go modules to local cache" | ||
| @go mod download |
There was a problem hiding this comment.
Keep go-mod-cache in the Makefile, do avoid differences vs gaia.
There was a problem hiding this comment.
Hmm, can you elaborate? AFAICT, cosmos-sdk hasn't had a "go-mod-cache" target since it was removed by cosmos/cosmos-sdk@6c1c2cc .
There was a problem hiding this comment.
There was a problem hiding this comment.
Opened a PR there: cosmos/gaia#2915
gibson042
force-pushed
the
gibson-2024-01-faster-make-agd
branch
from
dbba9ce
to
e2ff3af
Compare
Deploying agoric-sdk with
|
| Latest commit: |
670cb8a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5e341b7b.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-01-faster-make-a.agoric-sdk.pages.dev |
gibson042
force-pushed
the
gibson-2024-01-faster-make-agd
branch
from
88bd504
to
0d09636
Compare
…pstream * Replace synthetic "go-mod-cache" Makefile target with direct dependence upon go.sum. * Introduce support for `make SKIP_MOD_VERIFY=1` to avoid unnecessary expensive scans when e.g. tweaking referents of local-directory `replace $modulePath => ../path/to/module` directives in go.mod.
gibson042
force-pushed
the
gibson-2024-01-faster-make-agd
branch
from
0d09636
to
670cb8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make SKIP_MOD_VERIFY=1to avoid unnecessary expensive scans when e.g. tweaking referents of local-directoryreplace $modulePath => ../path/to/moduledirectives in go.mod.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
There is no formal place to document the new make variable, so it is instead directly mentioned in make output.
Testing Considerations
Manually verified expected behavior in various scenarios (e.g., running
makewithoutgo.modchanges).Upgrade Considerations
n/a