refactor: use @agoric/vow/vat.js
#9329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
reviewed
May 7, 2024
michaelfig
force-pushed
the
mfig-use-vow-vat
branch
from
9470706
to
d0189b5
Compare
Deploying agoric-sdk with
|
| Latest commit: |
d0189b5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://447145b9.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mfig-use-vow-vat.agoric-sdk.pages.dev |
michaelfig
force-pushed
the
mfig-use-vow-vat
branch
from
d0189b5
to
ae20e07
Compare
erights
approved these changes
May 7, 2024
There was a problem hiding this comment.
Hi @michaelfig , this is still Draft but already LGTM. What else is needed before this is ready for review?
I usually wait to see if CI passes before I R4R it. I just wasn't paying attention: thanks for your review! |
michaelfig
added
the
automerge:no-update
erights
added a commit
that referenced
this pull request
May 14, 2024
Staged on #9097 closes: #XXXX refs: #9231 #9321 #9329 #9097 ## Description Now that `watchPromise` is abstracted over zones and vows make use of that, we can simplify the test cases a lot. Should be a pure refactor with no externally observable effect. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations tests simpler. Otherwise, none ### Upgrade Considerations none
erights
added a commit
that referenced
this pull request
May 16, 2024
Staged on #9097 closes: #XXXX refs: #9231 #9321 #9329 #9097 ## Description Now that `watchPromise` is abstracted over zones and vows make use of that, we can simplify the test cases a lot. Should be a pure refactor with no externally observable effect. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations tests simpler. Otherwise, none ### Upgrade Considerations none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9321
Description
Update the preferred way of using SwingSet vat-compatible vows to import
@agoric/vow/vat.js.Also, as a drive-by in
@agoric/vow, avoidimport('./file.js').Typein favour of the@import {Type} from './file.js'Typescript 5.5 syntax.Security Considerations
Doesn't change any code semantics.
Scaling Considerations
n/a
Documentation Considerations
@agoric/vat-data/vow.jsis still available, as an alias for@agoric/vow/vat.js.Testing Considerations
n/a
Upgrade Considerations
No change in code functionality.