proto msg response types #9351
Merged
proto msg response types #9351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
dfc830b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f79f500.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-response-types.agoric-sdk.pages.dev |
0xpatrickdev
reviewed
May 9, 2024
packages/vats/src/localchain.js
Outdated
| @@ -68,8 +70,9 @@ const prepareLocalChainAccount = zone => | |||
| return E(allegedPurse).deposit(payment); | |||
| }, | |||
| /** | |||
| * @param {import('@agoric/cosmic-proto').TypedJson<unknown>[]} messages | |||
| * @returns {Promise<import('@agoric/cosmic-proto').TypedJson[]>} | |||
| * @template {TypedJson[]} MA messages array | |||
There was a problem hiding this comment.
Consider adding a hint to use typedJson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #9342
Description
Make it so executeTx gives the proper response message for each request message.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations