fix(vats): don't give all of bankManager to 1 account #9354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
d1f1630
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d0c44faf.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-localchain-1.agoric-sdk.pages.dev |
michaelfig
approved these changes
May 9, 2024
mergify bot
added a commit
that referenced
this pull request
May 9, 2024
follow-up to: #9086 ## Description In preparation for addressing excess authority (#9354): - To allow for state upgrade, rather than introducing the complexity of the power store in this initial version, reserve one property for future use - Require all localChain powers at intialization, which eliminates the need for the admin.setPower method. ### Security / Documentation Considerations n/a ### Scaling Considerations small constant factor change: removing the indirection thru the power store removes 1 syscall per access ### Testing Considerations existing tests suffice ### Upgrade Considerations code is not yet released / deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9342, #9193
stacked on
Description
Provide localchain accounts only with the
bankfor the relevant address, rather than giving them access to all accounts in the form of thebankManager.earlier discussion: https://github.com/Agoric/agoric-sdk/pull/9342/files#r1594791187
Security Considerations
bankManager was excess authority
Scaling / Documentation / Testing Considerations
Nothing significant: no scaling changes; existing docs/tests suffice.
Upgrade Considerations
code is not released / deployed