9063 chain lookup #9459
Merged
9063 chain lookup #9459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no value in runtime
Deploying agoric-sdk with
|
| Latest commit: |
9fdd77f
|
| Status: | 🚫 Build failed. |
dckc
approved these changes
Jun 5, 2024
| @@ -1,5 +1,10 @@ | |||
| /** | |||
| * @file Mocked Chain Info object until #8879 | |||
| * @file Mocked Chain Info object | |||
There was a problem hiding this comment.
I gave it a try but will save it for a next PR because it affects the a3p test too.
packages/orchestration/src/facade.js
Outdated
Comment on lines
164
to
165
| // TODO zone is a lot of power to hand down. If it's only used for | ||
| // `prepareCosmosOrchestrationAccount` we can do that in the parent scope |
There was a problem hiding this comment.
IIUC, making an async flow needs a durable zone.
I expect it can be a sub-zone and need not be the whole thing.
There was a problem hiding this comment.
ah yes. I'll remove this comment.
| agoricNames: bootstrap.agoricNames, | ||
| localchain: bootstrap.localchain, | ||
| orchestrationService: bootstrap.orchestration, | ||
| storageNode: bootstrap.storage.rootNode, |
There was a problem hiding this comment.
have we been passing the whole storage root to the contract? that seems weird.
(not a request for change)
| agoricNames, | ||
| localchain, | ||
| orchestrationService: orchestration, | ||
| storageNode: storage.rootNode, |
There was a problem hiding this comment.
hm. passing the whole storage root to a contract shouldn't be common
I'm not sure what to suggest
There was a problem hiding this comment.
I expect it'll change when we test writes to vstorage
mergify bot
added a commit
that referenced
this pull request
Jun 6, 2024
refs: #9063 ## Description More progress on #9063 Following up on #9459 Next I think I'll set up a tool to grab the chain-registry info for the chains in the checklist and bring them into agoricNames In parallel, @dckc is populating agoricNames with the chain _connection_ info which can be appended to even after the chain (graph node) is defined. ### Security Considerations no changes ### Scaling Considerations no changes ### Documentation Considerations no need ### Testing Considerations CI, including A3P proposal update ### Upgrade Considerations no yet deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9063
Description
Progress on #9063, looking up primary chain info by chainID. Modeled after https://github.com/Agoric/agoric-sdk/tree/dc-unk-chain-misc
Doesn't yet handle IBC connection info (
hostConnectionId,controllerConnectionId). I propose this is worth landing without that but invite reviewers to weigh in with requests.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations